New Export Trace Model #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to use the same drill hole message and deprecated the old message.
anskhanson
requested review from
ansjmoody and
ansnfernand
and removed request for
ansjmoody
ansnfernand
reviewed
Feb 27, 2024
ansnfernand
reviewed
Feb 27, 2024
…issed in the last commit
ansnfernand
reviewed
Feb 27, 2024
ansnfernand
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added export trace model and updated export trace reinforcement model to use the same drill hole message and deprecated the old message.
Before this gets approved make sure to:
[x] Update the version file
[x] Test proto file compilation
[] Ensure that the server and client code that uses the generated code from these files work