Skip to content

Fix version switcher styling #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Fix version switcher styling #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab2229a
Fix broken version switch styling
Revathyvenugopal162 Nov 16, 2022
5ad0ad3
Add style with specific color on active
Revathyvenugopal162 Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/ansys_sphinx_theme/static/css/ansys_sphinx_theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,12 @@ html[data-theme="dark"] .highlight pre {
}

#version_switcher_menu a.list-group-item.active {
background-color: var(--pst-color-background);
border-color: var(--pst-color-border);
color: var(--pst-color-text-base)
background-color: #D09735!important;
Copy link
Member

@jorgepiloto jorgepiloto Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to use this color, see https://www.color-hex.com/color/d09735.

I am not sure if this is in conflict with our style guidelines. I think it works fine for the dark theme, but for the light one it may not be the best.

Copy link
Contributor Author

@Revathyvenugopal162 Revathyvenugopal162 Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not conflicting IMO, since the navigation bar is always black (in dark and in light) and it is only at the time of hovering, if you are putting the dropdown. But i am open to change.

border-color: var(--pst-color-text-base)!important;
color: var(--pst-color-text-base)!important;
}

.list-group-item.active {
z-index: 2;
color: var(--pst-color-text-base)!important;
}