Ship a basic 404 page #83
Conversation
github-actions
bot
added
dependencies
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Apart from my previous comment saying that we should target the issues page of each specific repo (if possible), nothing else. LGTM!
jorgepiloto
force-pushed
the
feat/404-page
branch
from
4a46036 to
7f371b7
Compare
jorgepiloto
force-pushed
the
feat/404-page
branch
3 times, most recently
from
fa6496d to
5bcdea0
Compare
| ===== | ||
| This is unexpected. The page you are requesting does not exist. | ||
|
|
||
| If this page should exist, please contact `{{ theme_contact_mail }} <mailto:{{ theme_contact_mail }}`_. |
There was a problem hiding this comment.
Considering that some projects may not be linked to GitHub (see #38), we agreed on adding a new theme variable named contact_mail which is used in the 404.rst file.
There was a problem hiding this comment.
We will just have to start enforcing its use across the different docs, right?
There was a problem hiding this comment.
Yes, that's right. Since this is a third party extension, we need to configure it manually. Same happens with the numpydoc, for example.
|
Quick question @jorgepiloto - what's missing in this PR? Is it ready to merge? |
Nothing else to be added from my side. This is ready to be merged 👍🏽 |
|
Merging then! |
Resolves #72 by including a basic 404 page.