Skip to content

ci: Finish cicd #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 28, 2025
Merged

ci: Finish cicd #34

merged 22 commits into from
Jul 28, 2025

Conversation

@AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Jul 23, 2025

No description provided.

This was linked to issues Jul 23, 2025
Make sure that the workflow file is complete #19
Closed
Add release doc deploy and changelog action #20
Closed
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review July 23, 2025 12:11
RobPasMue
RobPasMue requested changes Jul 23, 2025
View reviewed changes
@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Jul 24, 2025
@AlejandroFernandezLuces AlejandroFernandezLuces changed the title maint: Finish cicd ci: Finish cicd Jul 24, 2025
@AlejandroFernandezLuces
Copy link
Contributor Author

AlejandroFernandezLuces commented Jul 24, 2025

The ansys/check-vulnerabilities action needs to be performed on a public repository. If the repository is private, the action will fail due to denied access.

I just realized this warning.. Should I remove/comment out the action while the repo is not released?

@RobPasMue
Copy link
Member

RobPasMue commented Jul 24, 2025

The ansys/check-vulnerabilities action needs to be performed on a public repository. If the repository is private, the action will fail due to denied access.

I just realized this warning.. Should I remove/comment out the action while the repo is not released?

Run it locally, fix any hit you find -- but comment it out from the workflow until released

@github-actions github-actions bot added the testing Anything related to testing label Jul 28, 2025
@AlejandroFernandezLuces
Copy link
Contributor Author

AlejandroFernandezLuces commented Jul 28, 2025 •
edited
Loading

@RobPasMue Need to merge for the release, feel free to review when you come back and I can open a new PR for the fixes 🙂

RobPasMue
RobPasMue approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 9b95a75 into main Jul 28, 2025
23 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the maint/finish-cicd branch July 28, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add release doc deploy and changelog action Make sure that the workflow file is complete

4 participants

@AlejandroFernandezLuces @RobPasMue @pyansys-ci-bot