-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Update supported version #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I'm not entirely sure about this... This is just a way to detect versions. I would leave it as is FMPOV.
|
I would instead add a clarification saying which versions are supported (i.e. the last 2 years) |
|
This would break compatibility with old versions needlesly IMO. We can stop supporting older versions without having to actively break library backwards compatibility, which is effortless for us. Let me add clarification in the documentation about supported versions 🙂 |
|
Sounds good - thanks @AlejandroFernandezLuces |
Yes, works for. Just make sure to not say that we are supporting version 23 or older while we are not at the company level. |
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I created a dedicated PR so we can easily dismiss it as it might lead to some discussion.
It is part of the tech review.
I would suggest that we only support the 2 last major versions.
If note, we need to clarify what "supported version" means.