Skip to content

Conversation

@MaxJPRey
Copy link
Contributor

@MaxJPRey MaxJPRey commented Oct 8, 2025

I created a dedicated PR so we can easily dismiss it as it might lead to some discussion.
It is part of the tech review.

I would suggest that we only support the 2 last major versions.

If note, we need to clarify what "supported version" means.

@github-actions github-actions bot added the enhancement New features or code improvements label Oct 8, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not entirely sure about this... This is just a way to detect versions. I would leave it as is FMPOV.

@RobPasMue
Copy link
Member

I would instead add a clarification saying which versions are supported (i.e. the last 2 years)

@AlejandroFernandezLuces
Copy link
Contributor

AlejandroFernandezLuces commented Oct 9, 2025

This would break compatibility with old versions needlesly IMO. We can stop supporting older versions without having to actively break library backwards compatibility, which is effortless for us.

Let me add clarification in the documentation about supported versions 🙂

@RobPasMue
Copy link
Member

Sounds good - thanks @AlejandroFernandezLuces

@MaxJPRey
Copy link
Contributor Author

MaxJPRey commented Oct 9, 2025

I would instead add a clarification saying which versions are supported (i.e. the last 2 years)

Yes, works for.

Just make sure to not say that we are supporting version 23 or older while we are not at the company level.
Maybe use the word compatible and not supported.

@RobPasMue RobPasMue changed the title FEAT: Update supported version feat: Update supported version Oct 10, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 10, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit a1b4b6f into main Oct 10, 2025
23 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the feat/supported_version branch October 10, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants