-
Notifications
You must be signed in to change notification settings - Fork 0
ci: Add ansys/actions/check-actions-security action and related fixes
#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nes for those using secrets
…isoning vulnerability
ansys/actions/check-actions-security action and related fixesansys/actions/check-actions-security action and related fixes
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thank you @ecoussoux-ansys for this PR! I mostly provided |
This PR introduces the
ansys/actions/check-actions-securityaction in the workflow file.github/workflows/cicd.ymland consequently in the CI of theansys-tools-common.This action is using
zizmorto perform an audit of the workflows defined in the.github/workflowsfolder.The PR addresses the findings surfaced by the
zizmoraudit on the workflow files (performed locally), resulting in the following changes:ansys/actionsas well as external ones) used in workflow files are now pinned with a commit SHA,persist-credentials: falseis now systematically used with the actionactions/checkout,envblock instead,permissionsare now defined on a job by job basis, while none are granted at the workflow level. Jobs that do not use secrets are not granted any specific permission,run_mapdl_tests.ymlis pinned to its SHA256 hash (found here),cache: 'pip'is removed when usingactions/setup-pythonto prevent cache-poisoning vulnerability.Lastly, the latest release v10.1.4 of
ansys/actionsis used here.Close #40.