Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

fix is_valid_executable_path() call for mechanical #55

Merged
merged 10 commits into from
Jun 20, 2023
Merged

fix is_valid_executable_path() call for mechanical #55

merged 10 commits into from
Jun 20, 2023

Conversation

@Gryfenfer97
Copy link
Contributor

@Gryfenfer97 Gryfenfer97 commented Jun 19, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited
Loading

Codecov Report

Merging #55 (22258d7) into main (304cfef) will decrease coverage by 0.25%.
The diff coverage is 60.00%.

❗ Current head 22258d7 differs from pull request most recent head 1252641. Consider uploading reports for the commit 1252641 to get more accurate results

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   69.72%   69.47%   -0.25%     
==========================================
  Files           3        3              
  Lines         251      249       -2     
==========================================
- Hits          175      173       -2     
  Misses         76       76

@Gryfenfer97 Gryfenfer97 requested a review from germa89 June 19, 2023 07:27
@Gryfenfer97 Gryfenfer97 marked this pull request as draft June 19, 2023 07:28
@Gryfenfer97 Gryfenfer97 marked this pull request as ready for review June 19, 2023 07:34
germa89
germa89 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@germa89 germa89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

I think you are needing some tests for the coverage to pass.

@Gryfenfer97
Copy link
Contributor Author

Gryfenfer97 commented Jun 19, 2023

I'm on it

@Gryfenfer97 Gryfenfer97 merged commit 18ee1c8 into main Jun 20, 2023
@Gryfenfer97 Gryfenfer97 deleted the fix/is-valid-executable-path-error branch June 20, 2023 10:06
germa89 pushed a commit that referenced this pull request Jun 21, 2023
@Gryfenfer97 @germa89
fix is_valid_executable_path() call for mechanical (#55)
44bd275 
* fix error

* simplify _is_common_executable_path
  * add back the version check and simplify _is_common_executable_path without any if
  * add tests for _is_common_executable
  * remove useless if statement since it is always True
  * try displaying v_version and ansys_version
  * fix _is_common_executable_path tests

* add some tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@germa89 germa89 germa89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: is_valid_executable_path() missing 1 required positional argument: 'exe_loc'

3 participants

@Gryfenfer97 @germa89