Skip to content

Conversation

@abhishekchitwar
Copy link
Contributor

Example to showcase the postprocessing with Ansys Flagship Simulations Results. (VTK is generated using pydpf-core).

@abhishekchitwar abhishekchitwar self-assigned this Jul 26, 2024
@github-actions github-actions bot added maintenance Package and maintenance related documentation Improvements or additions to documentation labels Jul 26, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.46%. Comparing base (b4edb39) to head (74d652d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   60.46%   60.46%           
=======================================
  Files          24       24           
  Lines         817      817           
=======================================
  Hits          494      494           
  Misses        323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abhishekchitwar and others added 3 commits July 29, 2024 12:11
…eld_data.py

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…eld_data.py

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…eld_data.py

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 29, 2024
abhishekchitwar and others added 5 commits July 29, 2024 12:12
…eld_data.py

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…eld_data.py

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…eld_data.py

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…eld_data.py

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…eld_data.py

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 29, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 29, 2024
@abhishekchitwar abhishekchitwar enabled auto-merge (squash) July 29, 2024 08:23
@AlejandroFernandezLuces
Copy link
Collaborator

AlejandroFernandezLuces commented Jul 29, 2024

Thanks for adding this example @abhishekchitwar 🙂

I'm a bit worried about having the fluent dependency in this repo. I believe it might cause dependency issues if we integrate this repo into fluent. Is it possible to include the required example files directly in this repository? If not, that's fine, we can always revisit this if PyFluent incorporates this tool.

@RobPasMue
Copy link
Member

I'm a bit worried about having the fluent dependency in this repo. I believe it might cause dependency issues if we integrate this repo into fluent. Is it possible to include the required example files directly in this repository? If not, that's fine, we can always revisit this if PyFluent incorporates this tool.

Well, since it is inside the docs target I wouldn't worry much about it. People will install the package only, or other additional targets. But the docs target is explicitly for building the documentation of this project.

@abhishekchitwar abhishekchitwar merged commit 28cd083 into main Jul 29, 2024
@abhishekchitwar abhishekchitwar deleted the doc/postprocess-example branch July 29, 2024 08:35
@RobPasMue
Copy link
Member

Looks like automerge was activated by @abhishekchitwar - sorry @AlejandroFernandezLuces, should have let it up to you to merge. I didn't see that automerge was active

@abhishekchitwar
Copy link
Contributor Author

@AlejandroFernandezLuces,

Thank you! This issue can be resolved by incorporating a download API in this library to facilitate downloading sample data from the PyAnsys example-data repository. There are no direct dependencies of Fluent apart from downloading example data.

@AlejandroFernandezLuces
Copy link
Collaborator

Looks like automerge was activated by @abhishekchitwar - sorry @AlejandroFernandezLuces, should have let it up to you to merge. I didn't see that automerge was active

No worries, it's good to go from my side 🙂

@AlejandroFernandezLuces
Copy link
Collaborator

@AlejandroFernandezLuces,

Thank you! This issue can be resolved by incorporating a download API in this library to facilitate downloading sample data from the PyAnsys example-data repository. There are no direct dependencies of Fluent apart from downloading example data.

We can do that if we have any conflicts with fluent at some point. For now let's keep it simple, thanks gain for adding the example 🚀

@abhishekchitwar
Copy link
Contributor Author

@RobPasMue @AlejandroFernandezLuces, Sorry for the auto-merged. I simply try used it 🙂. Thanks for the review & Feedback! Appreciate it!

@ahernsean
Copy link

ahernsean commented Jul 29, 2024

@abhishekchitwar, do note that this dataset has the bug that VTK still considers the mesh cells to be invalid. The values in these cells ought to be zero, not 0x34 (dec 52).
image

@RobPasMue
Copy link
Member

Is this bug coming from PyVista @ahernsean? Or is it because the VTK file has that invalid info?

@abhishekchitwar
Copy link
Contributor Author

@ahernsean,
I attempted an alternative approach (converting from CGNS to VTK), but I still did not obtain any valid cells. The state described in the VTK documentation is not clear, as it includes:

    Valid = 0x0,
    WrongNumberOfPoints = 0x01,
    IntersectingEdges = 0x02,
    IntersectingFaces = 0x04,
    NoncontiguousEdges = 0x08,
    Nonconvex = 0x10,
    FacesAreOrientedIncorrectly = 0x20,

The number from the previous snapshot shared by you or the one below suggests that the issue is related to FacesAreOrientedIncorrectly, as we previously discussed. Any suggestions!

image

@ahernsean
Copy link

@RobPasMue, yes, I believe DPF is likely orienting the faces of polyhedra incorrectly in some cases. @abhishekchitwar and I were working with Paul Profizi on this, who said he'd try a few things and get back to us.

@ahernsean
Copy link

The state described in the VTK documentation is not clear, as it includes:

    Valid = 0x0,
    WrongNumberOfPoints = 0x01,
    IntersectingEdges = 0x02,
    IntersectingFaces = 0x04,
    NoncontiguousEdges = 0x08,
    Nonconvex = 0x10,
    FacesAreOrientedIncorrectly = 0x20,

The mapping is clear. Your image suggests that the majority of your cells have a ValidityState of 48 (dec), which is 30 (hex). This corresponds to NoncontiguousEdges and Nonconvex. Precisely what that means about the input mesh is less clear. I would want to restrict down to one or two cells to see what might be happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants