Skip to content

feat: Add PyVista Qt support #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Nov 22, 2024
Merged

feat: Add PyVista Qt support #192

merged 51 commits into from
Nov 22, 2024

Conversation

@AlejandroFernandezLuces
Copy link
Collaborator

@AlejandroFernandezLuces AlejandroFernandezLuces commented Nov 20, 2024

No description provided.

@github-actions github-actions bot added testing Anything related to testing enhancement New features or code improvements labels Nov 20, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 20, 2024
@AlejandroFernandezLuces
Copy link
Collaborator Author

AlejandroFernandezLuces commented Nov 21, 2024

I've abstained from executing any Qt code in the actions... I think I've checked every stackoverflow issue related to this that ever existed.

Other solutions don't seem to work in this environment for some reason, installed libraries required by Qt are not linking properly:
https://github.com/ansys/ansys-tools-visualization-interface/actions/runs/11955723062/job/33328760518

@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review November 21, 2024 15:38
RobPasMue
RobPasMue reviewed Nov 21, 2024
View reviewed changes
@RobPasMue
Copy link
Member

RobPasMue commented Nov 22, 2024

More or less... let's talk later. I was thinking of reusing the PyVista interface methods as much as possible by calling the parent/super ones... and even refactoring whatever is needed on the PyVista interface to make it more combinable.

@AlejandroFernandezLuces
Revert "fix: Sys deps"
cb593a4 
This reverts commit aba32e4.
@AlejandroFernandezLuces
fix: Revert refactor commits
5678add 
Revert "fix: Sys deps"

This reverts commit aba32e4.

Revert "fix: Minor details"

This reverts commit 42a3459.

Revert "fix: Depenency pinning, remove sys deps"

This reverts commit e688320.

Revert "fix: Refactor to have independent backend"

This reverts commit 508b625.
@AlejandroFernandezLuces
Merge branch 'feat/add-pyvistaqt-support' of https://github.com/ansys…
c6c68d3 
…-internal/pyansys-visualizer into feat/add-pyvistaqt-support
@AlejandroFernandezLuces
fix: Review comments
7915d3b
@AlejandroFernandezLuces
fix: Commented code
a4ed118
@AlejandroFernandezLuces
fix: Revert code block comment in examples
b5995f1
@AlejandroFernandezLuces
fix: Add missing import check
74f6b87
@AlejandroFernandezLuces
Copy link
Collaborator Author

AlejandroFernandezLuces commented Nov 22, 2024

@RobPasMue Reverted the changes, feel free to re-review

RobPasMue
RobPasMue approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some few comments

@RobPasMue
Copy link
Member

RobPasMue commented Nov 22, 2024

Feel free to merge :)

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 7b1b62c into main Nov 22, 2024
25 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the feat/add-pyvistaqt-support branch November 22, 2024 15:02
@AlejandroFernandezLuces AlejandroFernandezLuces mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

No one assigned

Labels

enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlejandroFernandezLuces @RobPasMue @pyansys-ci-bot