fix: pyvista read-only behaviour #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandroFernandezLuces
approved these changes
Apr 21, 2025
ahernsean
reviewed
Apr 21, 2025
| # Make sure to pass new copies/objects to the mesh for the normal | ||
| # This should be fixed by PyVista eventually... it is coming from | ||
| # https://github.com/pyvista/pyvista/commit/2db1888a294a14e4f28a140d8aa0466d332912dc | ||
| return mesh.clip(normal=[elem for elem in plane.normal], |
There was a problem hiding this comment.
How about:
return mesh.clip(normal=plane.normal.copy(), origin=plane.origin)
or
return mesh.clip(normal=plane.normal[:], origin=plane.origin)
to make the intent clearer?
Member
Author
There was a problem hiding this comment.
Hi @ahernsean -- no worries, this should be a temporary fix. See pyvista/pyvista#7446
Nonetheless, we can't just assume "copy()" will exist since the type can be a simple tuple/list (for which the copy() method doesn't exist). Option 2 could be valid but I'd rather fix it in PyVista and remove this hack altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, inside PyVista, they have implented an operation when performing the clipping plane that is only allowed for numpy arrays with write access. If you pass in a read-only array, this fails. Passing in a new list will hack it (in the meantime) but this will have to be fixed in PyVista.
Opened PR: pyvista/pyvista#7446