fix: Improve kwargs processing in show
#312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
|
I believe this should be it, @germa89 @RobPasMue do you foresee any issues with this approach? |
RobPasMue
approved these changes
Jun 26, 2025
src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py
Show resolved
Hide resolved
…ta_interface.py Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
4 tasks
germa89
approved these changes
Jun 27, 2025
src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py
Outdated
Show resolved
Hide resolved
src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py
Outdated
Show resolved
Hide resolved
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
|
Merging! If that is okay with you I'll leave the release for monday, just to have time in case anything breaks 😶 |
I agree... it is Friyay!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improves changes from last release, where kwargs in PyVista
showmethod were split intoplotting_kwargsandshow_kwargs. Now they are mixed again and split inside the method, to avoid breaking changes in the method signature.