Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Collaborator

@AlejandroFernandezLuces AlejandroFernandezLuces commented Oct 3, 2025

This is how the buttons are looking at the moment:

Recording.2025-10-03.113855.mp4

Custom picking functionalities can not be added to trame directly, we would need to implement the picking capabilities independently for trame/vue.

Also, most buttons only work on "Trame" mode, which implies worse performance and some lag in click interaction. Let's keep the visualizer only available in that mode for the moment.

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Oct 3, 2025
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review October 3, 2025 09:42
@AlejandroFernandezLuces AlejandroFernandezLuces linked an issue Oct 3, 2025 that may be closed by this pull request
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Let's add the screenshot and HTML download functionalities, but apart from that - ready to merge!

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 356e381 into main Oct 6, 2025
23 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the feat/add-trame-buttons branch October 6, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add functionality buttons to Trame.

4 participants