fix: Fix duplicate printed lines when updating license header#422
fix: Fix duplicate printed lines when updating license header#422
Conversation
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Thanks for the fix @klmcadams. Could you help me understand what makes a line printed twice ? I tried to follow the flow in the code base and I'm stuck not understanding how this can happpen.
Since we only call non_recursive_file_check once, which loops on pre_commit_files, the if ... else ... statements should prevent us from facing that duplicate issue, no ?
|
Hi @SMoraisAnsys, no problem! This line |
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Thanks for the explanation ! Here are a few comments, LGTM otherwise
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Forgot to add my review comments xD
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
|
@klmcadams You need to add the import to |
|
@SMoraisAnsys, that's ok, no worries. I'll test it |
|
@SMoraisAnsys, it looks like all tests passed so I'm going to merge it! |
In v0.7.1, the "Successfully changed {file}" lines are printed twice when a file is changed. This fixes that issue