-
Notifications
You must be signed in to change notification settings - Fork 1
Remove upper bounds on dependencies #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the dependencies group with 5 updates: | Package | From | To | | --- | --- | --- | | [ansys-tools-path](https://github.com/ansys/ansys-tools-path) | `0.5.1` | `0.5.2` | | [ansys-dpf-composites](https://github.com/ansys/pydpf-composites) | `0.4.0` | `0.4.1` | | [types-protobuf](https://github.com/python/typeshed) | `4.25.0.20240410` | `4.25.0.20240417` | | [sphinx](https://github.com/sphinx-doc/sphinx) | `7.2.6` | `7.3.7` | | [sphinx-autodoc-typehints](https://github.com/tox-dev/sphinx-autodoc-typehints) | `2.0.1` | `2.1.0` | Updates `ansys-tools-path` from 0.5.1 to 0.5.2 - [Release notes](https://github.com/ansys/ansys-tools-path/releases) - [Changelog](https://github.com/ansys/ansys-tools-path/blob/main/CHANGELOG.md) - [Commits](ansys/ansys-tools-path@v0.5.1...v0.5.2) Updates `ansys-dpf-composites` from 0.4.0 to 0.4.1 - [Release notes](https://github.com/ansys/pydpf-composites/releases) - [Changelog](https://github.com/ansys/pydpf-composites/blob/main/release_checklist.rst) - [Commits](ansys/pydpf-composites@v0.4.0...v0.4.1) Updates `types-protobuf` from 4.25.0.20240410 to 4.25.0.20240417 - [Commits](https://github.com/python/typeshed/commits) Updates `sphinx` from 7.2.6 to 7.3.7 - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES.rst) - [Commits](sphinx-doc/sphinx@v7.2.6...v7.3.7) Updates `sphinx-autodoc-typehints` from 2.0.1 to 2.1.0 - [Release notes](https://github.com/tox-dev/sphinx-autodoc-typehints/releases) - [Changelog](https://github.com/tox-dev/sphinx-autodoc-typehints/blob/main/CHANGELOG.md) - [Commits](tox-dev/sphinx-autodoc-typehints@2.0.1...2.1.0) --- updated-dependencies: - dependency-name: ansys-tools-path dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: ansys-dpf-composites dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: types-protobuf dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: sphinx dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: sphinx-autodoc-typehints dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the dependencies group with 5 updates: | Package | From | To | | --- | --- | --- | | [ansys-tools-path](https://github.com/ansys/ansys-tools-path) | `0.5.1` | `0.5.2` | | [ansys-dpf-composites](https://github.com/ansys/pydpf-composites) | `0.4.0` | `0.4.1` | | [types-protobuf](https://github.com/python/typeshed) | `4.25.0.20240410` | `4.25.0.20240417` | | [sphinx](https://github.com/sphinx-doc/sphinx) | `7.2.6` | `7.3.7` | | [sphinx-autodoc-typehints](https://github.com/tox-dev/sphinx-autodoc-typehints) | `2.0.1` | `2.1.0` | Updates `ansys-tools-path` from 0.5.1 to 0.5.2 - [Release notes](https://github.com/ansys/ansys-tools-path/releases) - [Changelog](https://github.com/ansys/ansys-tools-path/blob/main/CHANGELOG.md) - [Commits](ansys/ansys-tools-path@v0.5.1...v0.5.2) Updates `ansys-dpf-composites` from 0.4.0 to 0.4.1 - [Release notes](https://github.com/ansys/pydpf-composites/releases) - [Changelog](https://github.com/ansys/pydpf-composites/blob/main/release_checklist.rst) - [Commits](ansys/pydpf-composites@v0.4.0...v0.4.1) Updates `types-protobuf` from 4.25.0.20240410 to 4.25.0.20240417 - [Commits](https://github.com/python/typeshed/commits) Updates `sphinx` from 7.2.6 to 7.3.7 - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES.rst) - [Commits](sphinx-doc/sphinx@v7.2.6...v7.3.7) Updates `sphinx-autodoc-typehints` from 2.0.1 to 2.1.0 - [Release notes](https://github.com/tox-dev/sphinx-autodoc-typehints/releases) - [Changelog](https://github.com/tox-dev/sphinx-autodoc-typehints/blob/main/CHANGELOG.md) - [Commits](tox-dev/sphinx-autodoc-typehints@2.0.1...2.1.0) --- updated-dependencies: - dependency-name: ansys-tools-path dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: ansys-dpf-composites dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: types-protobuf dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: sphinx dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: sphinx-autodoc-typehints dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…ub.com/ansys-internal/pyacp into dependabot/pip/dependencies-c82c246255
PipKat
reviewed
Apr 24, 2024
roosre
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove upper limits on dependencies. For context, see e.g. the discussion in
https://iscinumpy.dev/post/bound-version-constraints/
In short: downstream projects have no way to remove an artificial (wrong)
upper bound, but adding a missing one is easy. Since it's unknowable
which future versions will be compatible, it's better to err on the side of
allowing them, for the context of libraries.
In addition, we continuously check the newest dependency versions via
dependabot, and our CI is using pinned dependencies. As such, I believe we
can afford to leave out the upper limit.
Other changes:
not work as intended. This can be removed once Allow configuration of sort orders in a way that does not mess with the sphinx cache sphinx-gallery/sphinx-gallery#1286
is resolved.