Implement ply geometry export for modeling plies #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greschd
commented
Jul 2, 2024
greschd
force-pushed
the
feat/ply_geometry_export
branch
4 times, most recently
from
21694de to
c0fc82b
Compare
Wiz Scan Summary
|
roosre
approved these changes
Jul 3, 2024
| include_boundary: bool = True, | ||
| include_first_material_direction: bool = True, | ||
| include_second_material_direction: bool = True, | ||
| arrow_length: float = 1.0, |
Contributor
There was a problem hiding this comment.
Not sure if that is a reasonable default. What about something like model.average_element_size?
Member
Author
There was a problem hiding this comment.
Yeah, square root of average_element_size is consistent with the ACP GUI.
Add a helper to manage the minimum server version needed to run specific methods on tree objects. To implement this, the 'channel' stored in the tree objects was converted into a 'ServerWrapper' which contains the channel and the server version.
greschd
force-pushed
the
feat/ply_geometry_export
branch
from
c0fc82b to
08cc403
Compare
greschd
force-pushed
the
feat/ply_geometry_export
branch
from
c05ee24 to
50ca475
Compare
The ansys-mapdl-core package is incompatible with numpy 2.0. However, older versions did not declare this incompatibility. To avoid explicitly limiting the numpy version here (and thus missing when the incompatibility is resolved), we force a sufficiently new version of ansys-mapdl-core that does declare the incompatibility. Otherwise, 'poetry' resolves the new numpy version, breaking the installation of ansys-mapdl-core.
greschd
force-pushed
the
feat/ply_geometry_export
branch
from
61d51f7 to
dfc3391
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/adaptive_mesh_workflow #545 +/- ##
===============================================================
+ Coverage 91.98% 92.02% +0.04%
===============================================================
Files 82 82
Lines 4252 4287 +35
===============================================================
+ Hits 3911 3945 +34
- Misses 341 342 +1 ☔ View full report in Codecov by Sentry. |
greschd
added a commit
that referenced
this pull request
Aug 20, 2024
Merging the changes from #545 onto `main`. Add an `export_modeling_ply_geometries` method to the `Model`, which the geometry of all modeling plies Other changes: - Add a helper function for managing the version of the server which supports a particular feature. - Since that required knowing the server version at the `TreeObject` level, convert the `channel` member into a `ServerWrapper` which contains both the channel and version. - Force newer version of `ansys-mapdl-core`, to avoid poetry resolving numpy to version 2.0 and downgrading `ansys-mapdl-core`, since older versions do not declare their incompatibility with numpy 2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
export_modeling_ply_geometriesmethod to theModel, which the geometry of all modeling pliesOther changes:
TreeObjectlevel, convert thechannelmemberinto a
ServerWrapperwhich contains both the channel and version.