Implement ply geometry export for modeling plies #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an `export_modeling_ply_geometries` method to the `Model`, which the geometry of all modeling plies Other changes: - Add a helper function for managing the version of the server which supports a particular feature. - Since that required knowing the server version at the `TreeObject` level, convert the `channel` member into a `ServerWrapper` which contains both the channel and version. - Force newer version of `ansys-mapdl-core`, to avoid poetry resolving numpy to version 2.0 and down- grading `ansys-mapdl-core`, since older versions do not declare their incompatibility with numpy 2.0.
Wiz Scan Summary
|
…eometry_export_to_main
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
+ Coverage 91.93% 91.97% +0.04%
==========================================
Files 82 82
Lines 4242 4289 +47
==========================================
+ Hits 3900 3945 +45
- Misses 342 344 +2 ☔ View full report in Codecov by Sentry. |
Merged
roosre
approved these changes
Aug 18, 2024
Contributor
roosre
left a comment
roosre
left a comment
There was a problem hiding this comment.
Please check the comments. I think it would make sense to ad an argument to export_modeling_ply_geometries
…eometry_export_to_main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the changes from #545 onto
main.Add an
export_modeling_ply_geometriesmethod to theModel, which the geometry of all modeling pliesOther changes:
TreeObjectlevel, convert thechannelmember into aServerWrapperwhich contains both the channel and version.ansys-mapdl-core, to avoid poetry resolving numpy to version 2.0 and downgradingansys-mapdl-core, since older versions do not declare their incompatibility with numpy 2.0.