Skip to content

Conversation

@greschd
Copy link
Member

@greschd greschd commented Aug 28, 2024

Add a step to the tests on Python 3.12 for testing with the 2024R2 server version. [1]

Expected test failures (new features) are marked with the new xfail_before fixture. The
only current expected failure is the modeling ply geometry export test (added in 25.1).

Also fixes an issue with the clone method when unlink=True is specified: Any
fields unknown to the current client were retained. This caused an error on storing,
since those may be unknown linked objects. In the current case, the newly added
links to the Fabric caused this.
Calling DiscardUnknownFields() on the protobuf message fixes this.

[1] Once there are multiple released server versions to test, it probably makes sense to
put these tests into separate jobs.

@greschd
Copy link
Member Author

greschd commented Aug 28, 2024

Failing due to #574, I will re-create the tagged container from the customer portal artifacts.

@codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (b4bba30) to head (9e18580).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          82       82           
  Lines        4292     4293    +1     
=======================================
+ Hits         3988     3989    +1     
  Misses        304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd greschd linked an issue Aug 28, 2024 that may be closed by this pull request
@greschd greschd enabled auto-merge (squash) August 29, 2024 08:11
@greschd greschd merged commit 9a8bb9b into main Sep 3, 2024
@greschd greschd deleted the maint/test_on_released_server branch September 3, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add testing with 2024R2 release container

3 participants