Add 'supported_since' keywords to the gRPC property helpers #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 93.31% 93.33% +0.01%
==========================================
Files 84 85 +1
Lines 4445 4471 +26
==========================================
+ Hits 4148 4173 +25
- Misses 297 298 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Member
Author
Allow marking gRPC properties as supported since a specific server version. The `grpc_data_property_read_only` is given a `supported_since` keyword, and `grpc_data_property` is given two separate keywords `readable_since` and `writable_since`. Other changes: - Change the `xfail_before` test fixture to `raises_before_version`, which explicitly checks that a `RuntimeError` is raised when run on an older server version. - Move the `supported_since` implementation to a separate file. - In the CI definition, reuse the `DOCKER_IMAGE_NAME` variable in more places.
greschd
force-pushed
the
feat/supported_since_on_grpc_properties
branch
from
86c04f0 to
ee0d714
Compare
roosre
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow marking gRPC properties as supported since a specific server version. The
grpc_data_property_read_onlyis given asupported_sincekeyword, andgrpc_data_propertyis given two separate keywordsreadable_sinceandwritable_since.Other changes:
xfail_beforetest fixture toraises_before_version, which explicitly checks that aRuntimeErroris raised when run on an older server version.supported_sinceimplementation to a separate file.DOCKER_IMAGE_NAMEvariable in more places.