Improve error message on inexistent files with local server #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check that the file exists when calling the (no-op) `upload_file` method on the local file transfer strategy. This ensures a nice error is produced when trying to import an inexistent ACPH5 file, instead of failing on H5Open. Resolves #748.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 94.43% 94.98% +0.54%
==========================================
Files 109 109
Lines 5696 5698 +2
Branches 0 323 +323
==========================================
+ Hits 5379 5412 +33
+ Misses 317 285 -32
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roosre
approved these changes
Jan 9, 2025
SRaimondi
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check that the file exists when calling the (no-op)
upload_filemethod on the local file transfer strategy.This ensures a nice error is produced when trying to import an inexistent ACPH5 file, instead of failing on H5Open.
Resolves #748.