Normalize strings before converting to protobuf enum values #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow normalizing strings before converting them to a protobuf enum value. By default, the string is converted to lowercase. This means that all capitalizations of the string will be accepted, for example "SI", "Si", "si" will all be accepted in the unit system parameter. Closes #793.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 110 110
Lines 5815 5816 +1
Branches 338 338
=======================================
+ Hits 5522 5523 +1
Misses 292 292
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roosre
approved these changes
May 22, 2025
greschd
deleted the
fix/793-ignore-capitalization-in-unit_system-parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow normalizing strings before converting them to a protobuf enum value. By default, the string is converted to lowercase.
This means that all capitalizations of the string will be accepted, for example
"SI","Si","si"will all be accepted in the unit system parameter.Closes #793.