Skip to content

Fix: update the docs and auto function module with update of theme package. #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 23, 2023
Merged

Fix: update the docs and auto function module with update of theme package. #262

merged 5 commits into from
Feb 23, 2023

Conversation

@Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Feb 22, 2023 •
edited
Loading

  • update the docs
  • auto function module with update of ansys-sphinx-theme package.
  • update ansys-sphinx-theme

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies labels Feb 22, 2023
@github-actions github-actions bot added the bug Something isn't working label Feb 22, 2023
jorgepiloto
jorgepiloto approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @Revathyvenugopal162. Thanks for adding this.

@jorgepiloto jorgepiloto enabled auto-merge (squash) February 22, 2023 16:39
@jorgepiloto jorgepiloto force-pushed the fix/change-broken-link branch from 0ae2e50 to ac899d3 Compare February 22, 2023 21:27
@jorgepiloto
Copy link
Member

jorgepiloto commented Feb 22, 2023

Linking here ansys/ansys-sphinx-theme#212.

@jorgepiloto
Copy link
Member

jorgepiloto commented Feb 22, 2023

I just debug this a bit more and found the issue. We are not using the multi-version switcher in this repository since we continuously deploy. However, this is causing some undesired behavior.

Run the doc build increasing the verbosity "-vv". You will see that the build fails close to some "version_switcher" option. Activating it allowed to build to run.

Let us investigate more about this, @Revathyvenugopal162.

@jorgepiloto jorgepiloto mentioned this pull request Feb 22, 2023
Closed
RobPasMue
RobPasMue reviewed Feb 23, 2023
View reviewed changes
RobPasMue
RobPasMue approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we can wait until the problems are fixed

@Revathyvenugopal162
Copy link
Contributor Author

Revathyvenugopal162 commented Feb 23, 2023

I just debug this a bit more and found the issue. We are not using the multi-version switcher in this repository since we continuously deploy. However, this is causing some undesired behavior.

Run the doc build increasing the verbosity "-vv". You will see that the build fails close to some "version_switcher" option. Activating it allowed to build to run.

Let us investigate more about this, @Revathyvenugopal162.

Linking here ansys/ansys-sphinx-theme#214

Revathyvenugopal162
Revathyvenugopal162 commented Feb 23, 2023
View reviewed changes
@jorgepiloto jorgepiloto merged commit 3eb4074 into main Feb 23, 2023
@jorgepiloto jorgepiloto deleted the fix/change-broken-link branch February 23, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

@MaxJPRey MaxJPRey Awaiting requested review from MaxJPRey

Assignees

No one assigned

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Revathyvenugopal162 @jorgepiloto @RobPasMue