Skip to content

Conversation

@PipKat
Copy link
Member

@PipKat PipKat commented Mar 20, 2024

This PR cleans up the existing PyAnsys developer's doc so that it follows our style guidelines. Note that I have the Vale error again indicating that there are too many results (annotations) in the diff.

Changes made in this PR:

  • Set up code block examples using tabs as in others other parts of the dev guide. (I'm not sure if the "Define a caption and name for referencing a code block" section is showing correctly what would render in the documentation.)
  • Replaced occurrences of "via" as the Google style guide and others recommend avoiding this word.
  • Removed glossary as its inclusion (and correctness) was questioned long ago.
  • Add content on the naming format required for Python folders and files (underscore must be used as space delimiter) and recommended for RST folder and files (hyphen should be used for search optimization of the HTML documentation).
  • Add information on how to comment out lines if you are not using the sphinx.ext.todo extension but why adding and using this native Sphinx extension is recommended.
  • Document how to use the git clean -fdx . command to remove untracked files and directories.
  • Add info about how new user overall index.rst files (doc landing pages) use a grid of cards to present the organization of the documentation in a visual manner.

@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Mar 20, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 20, 2024
@RobPasMue
Copy link
Member

@dipinknair - since you've been working on vale recently, could you help out @PipKat on resolving the issues?

@PipKat PipKat marked this pull request as ready for review March 22, 2024 21:53
@PipKat PipKat requested a review from RobPasMue March 22, 2024 21:53
@PipKat
Copy link
Member Author

PipKat commented Mar 22, 2024

@RobPasMue @dipinknair Hi, Roberto. Dipin and I met on Friday afternoon to look at the Vale issues. We both agreed that it would be best for you to review and force merge this PR and then create and assign an issue for him to investigate. We don't want to ignore the Google HEADING rule to use sentence case. However, it's through errors for titles that are using sentence case. (The only capital letter in the title is the one on the initial word.) It's also throwing errors when proper nouns are used in titles, but those proper nouns should be fine because the exist in the project's accept.txt file. It will be easier to Dipin to investigate after this very large PR is merged. I have finished reviewing content in these dev guide sections: "Getting started," "How-to," and "Style." I can finish the last two remaining sections after Dipin's investigation. (Plus, I have some Dev portal and Ansys Store work to do early next week.)

@RobPasMue
Copy link
Member

Sounds good @dipinknair @PipKat - I will do a final review on Monday morning. Have a nice weekend!

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging!

@RobPasMue RobPasMue enabled auto-merge (squash) March 25, 2024 07:06
@RobPasMue RobPasMue disabled auto-merge March 25, 2024 07:07
@RobPasMue RobPasMue merged commit 95b5806 into main Mar 25, 2024
@RobPasMue RobPasMue deleted the docs/fixes_and_minor_edits branch March 25, 2024 07:12
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
* Clean up of files to follow doc style guidelines

* Clean up of more files to follow doc style guidelines

* Fix broken link

* More cleanup and some content additions

* More cleanup on Friday

* Run pre-commit and Vale; fix errors.

* Fix broken link

* Update doc/source/content-writing/content-how-tos/create-PR.rst

---------

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants