Skip to content

Conversation

@anscfrisson
Copy link
Contributor

@anscfrisson anscfrisson commented Apr 24, 2024

  • f0a6e25 doc/source/how-to/releasing.rst: use double quotes for variable expansion (otherwise INDEX_URL literally equals https://$PYANSYS_PYPI_PRIVATE_READ_PAT@pkgs.dev.azure.com/pyansys/_packaging/pyansys/pypi/simple/)
  • f002664 doc/source/how-to/releasing.rst: fix powershell nested variable

@anscfrisson anscfrisson requested a review from klmcadams April 24, 2024 14:14
@anscfrisson anscfrisson self-assigned this Apr 24, 2024
@anscfrisson anscfrisson changed the title doc/source/how-to/releasing.rst: use double quotes for variable expansion fix: doc/source/how-to/releasing.rst: use double quotes for variable expansion Apr 24, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 24, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Apr 24, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 1🔑

@anscfrisson anscfrisson changed the title fix: doc/source/how-to/releasing.rst: use double quotes for variable expansion fix: doc/source/how-to/releasing.rst: fix variables Apr 24, 2024
@anscfrisson
Copy link
Contributor Author

anscfrisson commented Apr 24, 2024

@RobPasMue Thanks for having approved this PR!

I have added another commit after you approved: f002664 doc/source/how-to/releasing.rst: fix powershell nested variable and reframed the scope of this PR in the title: fix variables.

The pre-commit.ci job over the first 2 commits initially failed with:

timeout waiting for merge ref

I tested my changes locally with pre-commit run --files doc/source/how-to/releasing.rst which did not change the file.

Since I could not re-run the precommit.ci job, I tried to bypass the pre-commit.ci checks by pushing a commit: git commit --allow-empty -m"[skip pre-commit.ci]", but the pre-commit.ci passed anyway.

What are the usual ways to solve pre-commit.ci jobs failing with timeout waiting for merge ref?

@RobPasMue
Copy link
Member

First time I see those fails... pretty weird! Seems like something transient anyway. Thanks for the PR. Merging now!

@RobPasMue RobPasMue merged commit b6df04c into main Apr 24, 2024
@RobPasMue RobPasMue deleted the doc/releasing/variable-expansion branch April 24, 2024 15:10
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
* doc/source/how-to/releasing.rst: use double quotes for variable expansion

* doc/source/how-to/releasing.rst: fix powershell nested variable

* [skip pre-commit.ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants