Skip to content

Conversation

@PipKat
Copy link
Member

@PipKat PipKat commented Apr 24, 2024

The edits made in this PR are minor, mostly formatting and stye issues found while skimming the rendered documentation. Note that when there were multiple links to the same topic on a page, I removed all but the first link. On any given page, you only want to link on the first reference (unless the page is long and having another link much lower on the page would save the user from a lot of scrolling). Linking each time ends up giving the page a polka dot appearance.

@Revathyvenugopal162 I ran into the same problem running Vale locally here as I did on PyAnsys Quarto Cheat Sheet PR #11.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 24, 2024
@PipKat PipKat changed the title Doc/fix minor formatting issues Doc/fix minor formatting and style issues Apr 24, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall edits LGTM! Just left a minor comment

PipKat and others added 2 commits April 25, 2024 11:52
Add corrections for mistakes found by Roberto and Revathy

Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@PipKat PipKat merged commit e9a051b into main Apr 25, 2024
@PipKat PipKat deleted the doc/fix_minor_formatting_issues branch April 25, 2024 15:56
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
* Minor fixes

* Minor fixes based on skimming rendered doc

* Additional edits

* Fix Vale issues

* Resolve doc build errors

* Edit to add-sphinx-extensions

* Resolve link issues causing doc build failure

* Fix mistake

* Apply suggestions from code review

Add corrections for mistakes found by Roberto and Revathy

Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

---------

Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants