feat: clarification on using dependency groups and extras #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
github-actions
bot
added
documentation
SMoraisAnsys
approved these changes
Apr 4, 2025
Contributor
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
There was a problem hiding this comment.
LGTM, I left minor comments
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
greschd
reviewed
Apr 4, 2025
…com/ansys/pyansys-dev-guide into feat/clarification-dependency-goups
greschd
approved these changes
Apr 4, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
* feat: clarification on using dependency groups and extras * chore: removing TODO * Update doc/source/how-to/packaging.rst Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> * Update doc/source/how-to/packaging.rst Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> * docs: adapting to @greschd's suggestions --------- Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Contributor
|
Thanks @RobPasMue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says. Coming from dev meeting feedback raised by @greschd