Skip to content

Conversation

@RobPasMue
Copy link
Member

Description

Handling v0/v1 imports properly for initialization. Rest of the stubs have not been adapted. Showcasing as well how to test v1:

from ansys.geometry.core import Modeler
modeler = Modeler(host="localhost", port=654, proto_version="v0")  # For testing v0
modeler = Modeler(host="localhost", port=654, proto_version="v1")  # For testing v1
print(modeler)
modeler.close()

Once the v1 stubs are implemented properly, we can implement #2366

Issue linked

None

@RobPasMue RobPasMue self-assigned this Nov 11, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner November 11, 2025 16:53
@RobPasMue RobPasMue changed the title Feat/v1 fix feat: properly handling v0 and v1 initialization Nov 11, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Nov 11, 2025
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.20%. Comparing base (d8d5c4c) to head (4a7a6aa).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/_grpc/_version.py 43.75% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2368      +/-   ##
==========================================
- Coverage   95.36%   95.20%   -0.16%     
==========================================
  Files         168      168              
  Lines       11101    11103       +2     
==========================================
- Hits        10586    10571      -15     
- Misses        515      532      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit 1ef2779 into main Nov 12, 2025
51 checks passed
@RobPasMue RobPasMue deleted the feat/v1-fix branch November 12, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants