Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

As title says
Will likely rename the parts stub as it is only a legacy export method

Issue linked

Related to #2388

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Dec 2, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner December 2, 2025 13:08
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 10.34483% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.62%. Comparing base (1dc6cd4) to head (d047aac).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v1/conversions.py 9.09% 20 Missing ⚠️
...ansys/geometry/core/_grpc/_services/v1/commands.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2432      +/-   ##
==========================================
- Coverage   91.80%   91.62%   -0.18%     
==========================================
  Files         169      169              
  Lines       11813    11838      +25     
==========================================
+ Hits        10845    10847       +2     
- Misses        968      991      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) December 2, 2025 13:28
@jacobrkerstetter jacobrkerstetter merged commit 4f32d9c into main Dec 2, 2025
51 checks passed
@jacobrkerstetter jacobrkerstetter deleted the chore/v1_parts_commands_impl branch December 2, 2025 13:49
@jacobrkerstetter jacobrkerstetter mentioned this pull request Dec 2, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants