Skip to content

Conversation

jfthuong
Copy link
Contributor

@jfthuong jfthuong commented Mar 7, 2022

No description provided.

@rlagha
Copy link
Contributor

rlagha commented Mar 7, 2022

hi @jfthuong , thanks for this fix, I'm correcting some issues related to the validation pipelines

dummy commit
@jfthuong
Copy link
Contributor Author

jfthuong commented Mar 7, 2022

@rlagha Au plaisir.

@rlagha
Copy link
Contributor

rlagha commented Mar 7, 2022

@jfthuong could you please update your branch with master and commit again?
merci :)

@rlagha
Copy link
Contributor

rlagha commented Mar 8, 2022

@jfthuong , the issue is due to the fork, please could you create a branch directly from master? We will work to fix the issue related to the forking.

@jfthuong
Copy link
Contributor Author

jfthuong commented Mar 9, 2022

@rlagha I believe I don't have the write to work on a branch. ... but maybe I'm wrong? ;)

@akaszynski
Copy link
Contributor

Reason why this is failing is we're not allowing secrets to be passed to forks. This is consistent with standard practices to avoid allowing external contributors to potentially steal secrets or tokens.

Since this PR is clearly fine and there's no reason why the checks should be failing, I'm just merging it.

@akaszynski akaszynski merged commit 6040984 into ansys:master Mar 11, 2022
@jfthuong
Copy link
Contributor Author

Thanks Alex @akaszynski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants