Fix plot behavior when using keywords screenshot and off_screen #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to pv.Plotter() when it should only be given to pv.show(), just like the "screenshot" kwarg.
…book. Tested with Issue59.ipynb. Linked to Issue59 of PyDPF-Post
|
Rerunning ci by closing/opening |
anslpa
reviewed
May 19, 2022
ansys/dpf/core/meshed_region.py
Outdated
| notebook, | ||
| shell_layers, | ||
| off_screen, | ||
| # off_screen, |
There was a problem hiding this comment.
@PProfizi loose of compatibility with potential user scripts ? Is it wanted ?
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
+ Coverage 85.55% 85.77% +0.21%
==========================================
Files 52 52
Lines 5650 5700 +50
==========================================
+ Hits 4834 4889 +55
+ Misses 816 811 -5 |
…t(field_container)
…ifferent fields on the same mesh. MeshedRegion.grid has to set active scalar field to None.
|
All plotting has been moved to the new DpfPlotter for 3D plotting. Example for basic_plotting is working. |
# Conflicts: # ansys/dpf/core/plotter.py
…he grid getter level was too harsh. It was needed for add_node_labels
…ple possible backends) and rename _InternalPlotter to _PyVistaPlotter.
Test plot_contour_with_vtk is deprecated and only tested for legacy Plotter.
…chart is not implemented yet for DpfPlotter.
… DpfPlotter, as plot_contour is necessary. Limit this PR to fixing keywords, not changing signatures or global behavior.
cbellot000
reviewed
May 30, 2022
cbellot000
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #193
Fixed the behavior to have what would be expected.
Still have to add tests, update the docstrings (some arguments are now kwargs), and update the examples.
PS: I have modified the Plotter class, while work is underway to deprecate this and use DpfPlotter instead. This behavior should be copied when migrating plot_contour to the DpfPlotter.
PPS: when initializing a Plotter directly and then calling plot_contour from it, the off_screen keyword must be given when creating the Plotter as it will be an attribute of this Plotter instance, whereas the screenshot keyword should be given to plot_contour (which is logical but should be explained).