Skip to content

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Apr 7, 2022

The ImportWarning when using an incompatible version of ansys.grpc.dpf is now clearer and give a link to the Compatibility section in the docs.
The previous message stated "2022R1 Ansys unified install is available" instead of "unavailable".
Also changed the raise of InvalidPortError as the use of namespace errors conflicted with the use of variable errors in the preceding lines of code.

@PProfizi PProfizi requested review from cbellot000 and rlagha April 7, 2022 09:49
f" with the command: \n"
f" pip install ansys-grpc-dpf=={right_grpc_module_version}"
)
# raise ImportWarning(f"2022R1 Ansys unified install is available. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi the goal of this message is also to inform the user that a newer Ansys version is available and can be installed. This is important to mention

Copy link
Contributor Author

@PProfizi PProfizi Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlagha , ok, noted, I modified the message to:

An incompatibility has been detected between the DPF server version (2.0 from Ansys 2021R2) and the ansys-grpc-dpf version installed (0.4.0). Please consider using the latest DPF server available in the 2022R1 Ansys unified install.
To follow the compatibility guidelines given in https://dpfdocs.pyansys.com/getting_started/index.html#client-server-compatibility while still using DPF server 2.0, please install version 0.3.0 of ansys-grpc-dpf with the command:
pip install ansys-grpc-dpf==0.3.0

@rlagha rlagha requested a review from JennaPaikowsky April 7, 2022 10:42
@PProfizi PProfizi merged commit 0b2a046 into master Apr 7, 2022
@PProfizi PProfizi deleted the pprofizi/fix_Import_warning_wrong_grpc_version branch April 7, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants