Skip to content

Conversation

jose-henriquezroa
Copy link
Contributor

Updated distributed post processing examples.

@@ -1,94 +1,115 @@
"""
.. _ref_distributed_total_disp:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You lost the reference here but not in the other examples, is that on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it wasn't intentional. I will add it back.

Distributed post without client connection to remote processes with Operators
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This example shows how distributed files can be read and post processed
on distributed processes. After remote post processing, results a merged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"are" merged

epub_exclude_files = ["search.html"]

# GraphViz configuration
graphviz_output_format = 'svg'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the same time as correcting the "are" in the other file, could you please add a newline at the end of this file? It's just to comply with standards, and if this was the only thing to change I would not ask you a new commit just for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I will do that.

@PProfizi
Copy link
Contributor

PProfizi commented Apr 11, 2022

It does not appear to create the graphviz images correctly despite successfully building the doc:
image

@PProfizi
Copy link
Contributor

image

Do you think it would be possible to manage the font size in the graphs?
Some images are small and the font is big, some images are bigger and the font gets a lot smaller. It also does not seem to use the whole width of the text?

pushd .
cd ../docs/
call make clean
:: call make clean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jose-henriquez-roa I think that you didn't mean to commit that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this back when I had yet to ask whether there was a way to get around the documentation build timeout error. I was just testing whether removing the make clean would reduce the build time, I added it back afterwards.

"""
.. _ref_distributed_total_disp:
Distributed post without client connection to remote processes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jose-henriquez-roa could you please rename this example to: "Post processing of displacement on distributed processes"

# started. Operator instances will be created on each of those servers to
# address each a different result file.
# In this example, we will post process an analysis distributed in 2 files,
# we will consequently require 2 remote processes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# we will consequently require 2 remote processes
# we will consequently require 2 remote processes.

@@ -1,14 +1,15 @@
"""
.. _ref_distributed_delegate_to_server:
.. _ref_distributed_total_disp_op:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this example is the same as the first one, we can remove this file

"""
.. _ref_distributed_workflows_on_remote:
Connect operator chains on different processes implicitly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename this one to: "Create custom workflow on distributed processes."

To help understand this example the following diagram is provided. It shows
the operator chain used to compute the final result.
.. image:: 02-operator-dep.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this drawing, could you please add a datasource as an input of "response"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and maybe rename merge as "merge_fields"

# started. Operator instances will be created on each of those servers to
# address each a different result file.
# In this example, we will post process an analysis distributed in 2 files,
# we will consequently require 2 remote processes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# we will consequently require 2 remote processes
# we will consequently require 2 remote processes.

# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# In this workflow we merge the modal basis, the meshes, read the modal response
# and expand the modal response with the modal basis
# In the follwing series of operators we merge the modal basis, the meshes, read
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# In the follwing series of operators we merge the modal basis, the meshes, read
# In the following series of operators we merge the modal basis, the meshes, read

@jose-henriquezroa jose-henriquezroa merged commit 9e6215c into master Apr 13, 2022
@jose-henriquezroa jose-henriquezroa deleted the doc/update_post_processing_examples branch April 13, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants