fix: retro of result_coordinate_system for DPF < 251.1.pre1 #2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te_system (#2556) Co-authored-by: PProfizi <100710998+PProfizi@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2555 +/- ##
==========================================
+ Coverage 84.11% 84.13% +0.02%
==========================================
Files 91 91
Lines 10706 10706
==========================================
+ Hits 9005 9008 +3
+ Misses 1701 1698 -3 |
BClappe
reviewed
Aug 21, 2025
|
Some tests with 'continue-on-error: true' have failed:
|
BClappe
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2534
The internal name for
result.coordinate_systemwas changed frommapdl::rst::CSto the genericCS. This makes sure the Python operator class tries the former internal name if the new one fails.