Fixes the use of notebook argument for plot commands #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otter.plot_contour
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 85.88% 85.86% -0.03%
==========================================
Files 52 52
Lines 5705 5695 -10
==========================================
- Hits 4900 4890 -10
Misses 805 805 |
…ts on a Jupyter notebook.
anslpa
reviewed
Jun 13, 2022
| else: | ||
| import pyvista as pv | ||
| pv_version = pv.__version__ | ||
| version_to_reach = '0.32.0' |
There was a problem hiding this comment.
@anslpa I did, I found a bug, I fixed it, it should work :)
anslpa
approved these changes
Jun 13, 2022
cbellot000
pushed a commit
that referenced
this pull request
Jul 8, 2022
* Fixes the use of notebook argument for plot commands going through Plotter.plot_contour * Fixing kwargs in plot_contour for call to pv.Plotter.show with cpos_return * Update the example to show "notebook=False" is required for screenshots on a Jupyter notebook. * Fix an error with pv.Plotter.__init__ * Fix support for cpos_return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in a Jupyter notebook, the notebook=False argument was not working when using a plot command going through Plotter.plot_contour