Add a file.exists() check for the server executable. #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 85.76% 85.88% +0.12%
==========================================
Files 52 52
Lines 5704 5705 +1
==========================================
+ Hits 4892 4900 +8
+ Misses 812 805 -7 |
cbellot000
approved these changes
Jun 10, 2022
cbellot000
pushed a commit
that referenced
this pull request
Jul 8, 2022
* Add a file.exists() check for the server executable. * Resolve flake8 * Adding a test * Exclude Linux lines from coverage for now * Trying out actually running the test_launcher.py tests for server version 2.0 and above * Fixed the test_start_local # Conflicts: # ansys/dpf/core/server.py # tests/test_launcher.py
cbellot000
added a commit
that referenced
this pull request
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #104