Skip to content

Fix support for show_axes and scalar bar title for plot_contour #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Fix support for show_axes and scalar bar title for plot_contour #263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a77c93
Fix support for show_axes and scalar bar title for plot_contour
PProfizi Jun 14, 2022
a23b9dd
Refactor scalar bar title gestion for plot_contour, as well as add_fi…
PProfizi Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions ansys/dpf/core/plotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def __init__(self, **kwargs):

def add_mesh(self, meshed_region, **kwargs):

self._set_scalar_bar_title(kwargs)
kwargs = self._set_scalar_bar_title(kwargs)

# Set defaults for PyDPF
kwargs.setdefault("show_edges", True)
Expand Down Expand Up @@ -131,24 +131,10 @@ def add_field(self, field, meshed_region=None, show_max=False, show_min=False,
label_text_size=30, label_point_size=20, **kwargs):
# Get the field name
name = field.name.split("_")[0]
# Import pyvista
try:
import pyvista as pv
except ModuleNotFoundError:
raise ModuleNotFoundError(
"To use plotting capabilities, please install pyvista "
"with :\n pip install pyvista>=0.24.0"
)
pv_version = pv.__version__
version_to_reach = '0.30.0'
meet_ver = meets_version(pv_version, version_to_reach)
if meet_ver:
# use scalar_bar_args
scalar_bar_args = {'title': name}
kwargs.setdefault("scalar_bar_args", scalar_bar_args)
else:
# use stitle
kwargs.setdefault("stitle", name)
kwargs.setdefault("stitle", name)

kwargs = self._set_scalar_bar_title(kwargs)

kwargs.setdefault("show_edges", True)
kwargs.setdefault("nan_color", "grey")

Expand Down Expand Up @@ -291,6 +277,7 @@ def _set_scalar_bar_title(self, kwargs):
else:
if self._plotter.scalar_bar.GetTitle() is None:
kwargs.setdefault("stitle", stitle)
return kwargs


class DpfPlotter:
Expand Down Expand Up @@ -716,7 +703,15 @@ def plot_contour(
# add meshes
kwargs.setdefault("show_edges", True)
kwargs.setdefault("nan_color", "grey")

# Set the scalar bar title
kwargs.setdefault("stitle", name)
kwargs = self._internal_plotter._set_scalar_bar_title(kwargs)

# show axes
show_axes = kwargs.pop("show_axes", None)
if show_axes:
self._internal_plotter._plotter.add_axes()

text = kwargs.pop('text', None)
if text is not None:
Expand Down