Skip to content

Conversation

@koubaa
Copy link
Collaborator

@koubaa koubaa commented Dec 1, 2025

it partially worked when inserting to card sets, except it always assumed that insertions go to the end. Extend support to insertions into keywords and use the specified index

fixes #956

it partially worked when inserting to card sets, except it always
assumed that insertions go to the end. Extend support to insertions
into keywords and use the specified index
@koubaa koubaa requested a review from a team as a code owner December 1, 2025 18:27
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.72%. Comparing base (311c87b) to head (892e957).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files          79       79           
  Lines       10681    10681           
=======================================
  Hits         8409     8409           
  Misses       2272     2272           
Flag Coverage Δ
keywords 99.63% <ø> (ø)
run 49.19% <ø> (ø)
unittests 78.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koubaa koubaa merged commit fee6d43 into main Dec 1, 2025
31 checks passed
@koubaa koubaa deleted the out-of-bound-insertions branch December 1, 2025 19:03
koubaa added a commit that referenced this pull request Dec 4, 2025
Co-authored-by: Mohamed Koubaa <koubaa@github.com>
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in keyword class generation

4 participants