-
Notifications
You must be signed in to change notification settings - Fork 4
Template editor JSON exporting and importing #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 60.17% 60.56% +0.39%
==========================================
Files 22 22
Lines 6626 6702 +76
Branches 1264 1280 +16
==========================================
+ Hits 3987 4059 +72
Misses 2269 2269
- Partials 370 374 +4 ☔ View full report in Codecov by Sentry. |
margalva
approved these changes
Dec 17, 2024
viseshrp
reviewed
Dec 17, 2024
viseshrp
requested changes
Dec 17, 2024
viseshrp
reviewed
Dec 18, 2024
viseshrp
requested changes
Dec 18, 2024
zhang-yuanrui
commented
Dec 18, 2024
zhang-yuanrui
commented
Dec 18, 2024
zhang-yuanrui
commented
Dec 18, 2024
viseshrp
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fulfill 2 parts of functionalities:
get_templates_as_jsonload_templatesThings not done yet in this PR:
Please note that: in this PR,
load_templatesis supposed to be working when given a correct JSON input, ideally, the original / unchanged JSON file fromget_templates_as_json