Skip to content

Conversation

@viseshrp
Copy link
Collaborator

@viseshrp viseshrp commented Apr 11, 2025

Features
Added add_properties alias for templates.

Started making use of dynamic template properties.

Replaced string-based types with Enums for cleaner, more structured code.

Added ignore_primary_keys option to backup_database.

Allowed Path objects in backup_database and restore_database.

Introduced support for cross-db copy in create_objects.

Rewrote error handling in various areas to improve clarity and robustness.

Bug Fixes
Fixed dynamic property reference issues in template properties.

Fixed type checks in find method to ensure consistency.

Fixed tests in test_adr.py to ensure correct behavior.

Fixed create_objects cross-db copy to ensure data consistency across databases.

Fixed issues with backup_database not handling foreign keys properly.

Updated test_template.py with better test coverage and error handling.

Fixed permission conflicts and addressed database issues during restores (with --natural-foreign flag).

Miscellaneous
Updated CI configuration (ci_cd.yml).

Disabled CI for specific conditions.

Updated test_adr.py and test_template.py for better test coverage and added more specific assertions.

Improved documentation with clearer setup instructions and example use cases.

Renamed functions and files for consistency.

@viseshrp viseshrp requested a review from phchen95 April 11, 2025 20:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 99.09091% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.86%. Comparing base (2cf7b70) to head (bc004c2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/dynamicreporting/core/serverless/adr.py 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   75.86%   78.86%   +3.00%     
==========================================
  Files          25       25              
  Lines        7027     7065      +38     
  Branches     1335     1335              
==========================================
+ Hits         5331     5572     +241     
+ Misses       1248     1064     -184     
+ Partials      448      429      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@viseshrp viseshrp force-pushed the vr/slst branch 2 times, most recently from ee87a5e to c09b6de Compare April 12, 2025 00:26
Update template.py

refactor

use enums for types
Update test_adr.py

update tests

Update test_adr.py

update tests
@viseshrp viseshrp merged commit 9196e10 into main Apr 15, 2025
19 checks passed
@viseshrp viseshrp deleted the vr/slst branch April 15, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants