Skip to content

Conversation

@viseshrp
Copy link
Collaborator

No description provided.

@viseshrp viseshrp requested a review from margalva September 18, 2025 19:17
margalva
margalva previously approved these changes Sep 18, 2025
margalva
margalva previously approved these changes Sep 18, 2025
@viseshrp
Copy link
Collaborator Author

@margalva Please don't approve yet. I will let you know when the tests are fixed.

@viseshrp viseshrp requested review from margalva and removed request for margalva September 19, 2025 16:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 78.66667% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.06%. Comparing base (d6c3488) to head (27d3cdb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../dynamicreporting/core/serverless/html_exporter.py 78.08% 6 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   81.01%   81.06%   +0.04%     
==========================================
  Files          28       28              
  Lines        7824     7890      +66     
  Branches     1455     1466      +11     
==========================================
+ Hits         6339     6396      +57     
  Misses       1028     1028              
- Partials      457      466       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This reverts commit 30d7c01.
@viseshrp viseshrp changed the title use custom static and media urls in html export allow custom static and media urls in html export Sep 22, 2025
@viseshrp viseshrp requested a review from margalva September 22, 2025 19:35
@viseshrp
Copy link
Collaborator Author

@margalva Tests have been fixed. Please take a look when you can.

@viseshrp viseshrp enabled auto-merge (squash) September 22, 2025 19:36
@viseshrp viseshrp merged commit b9166c0 into main Sep 22, 2025
19 checks passed
@viseshrp viseshrp deleted the vrajendr/hx-urls branch September 22, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants