Skip to content

Conversation

@margalva
Copy link
Collaborator

Fix a bug in template API: get_filter and set_filter was used both for high-level template method and for the filter value in the generator for table filter by value. Rename the methods, and leave set_filter as deprecated method for backward compatibility.

As we're at it, start migrating the lower level API documentation over pydynamicreporting docs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (231525f) 75.75% compared to head (95238ec) 75.64%.

Files Patch % Lines
...nsys/dynamicreporting/core/utils/report_objects.py 52.38% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   75.75%   75.64%   -0.11%     
==========================================
  Files          16       16              
  Lines        4953     4972      +19     
  Branches     1048     1050       +2     
==========================================
+ Hits         3752     3761       +9     
- Misses        851      860       +9     
- Partials      350      351       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@margalva margalva merged commit ccac268 into main Dec 1, 2023
@margalva margalva deleted the fix/set_filter_method branch December 1, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants