Skip to content

FEAT: Layout file warnings #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 24, 2025
Merged

FEAT: Layout file warnings #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e5a8ce1
REFACTOR: EDB configuration example for DCIR setup
gkorompi Nov 28, 2024
6ee7f6f
FEATURE: log errors for layout_file
gkorompi Oct 23, 2025
caf1d31
MISC: Auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 23, 2025
942e917
Delete examples/use_configuration/dcir.py
gkorompi Oct 23, 2025
96442db
chore: adding changelog file 1602.added.md [dependabot-skip]
pyansys-ci-bot Oct 24, 2025
a7e3acd
Merge branch 'main' into layout_file_warnings
gkorompi Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/1602.added.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Layout file warnings
10 changes: 7 additions & 3 deletions src/pyedb/dotnet/edb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,11 +839,15 @@ def import_layout_file(
try:
subprocess.run(cmd_translator, check=True) # nosec
except subprocess.CalledProcessError as e: # nosec
raise RuntimeError("An error occurred while translating board file to ``edb.def`` file") from e
raise RuntimeError(
"An error occurred while translating board file to ``edb.def`` file. Please check the log file."
) from e
if not os.path.exists(os.path.join(working_dir, aedb_name)):
raise RuntimeWarning(f"Translator failed. command : {' '.join(cmd_translator)}")
raise RuntimeWarning(
f"Translation failed. command : {' '.join(cmd_translator)}. Please check the log file."
)
else:
self.logger.info("Translation correctly completed")
self.logger.info("Translation successfully completed")
self.edbpath = os.path.join(working_dir, aedb_name)
return self.open_edb()

Expand Down
11 changes: 7 additions & 4 deletions src/pyedb/grpc/edb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,12 +875,15 @@ def import_layout_file(
try:
subprocess.run(cmd_translator, check=True) # nosec
except subprocess.CalledProcessError as e: # nosec
raise RuntimeError("An error occurred while translating board file to ``edb.def`` file") from e
raise RuntimeError(
"An error occurred while translating board file to ``edb.def`` file. Please check the log file."
) from e
if not os.path.exists(os.path.join(working_dir, aedb_name)):
self.logger.error("Translator failed to translate.")
return False
raise RuntimeWarning(
f"Translation failed. command : {' '.join(cmd_translator)}. Please check the log file."
)
else:
self.logger.info("Translation correctly completed")
self.logger.info("Translation successfully completed")
self.edbpath = os.path.join(working_dir, aedb_name)
return self.open_edb()

Expand Down
Loading