Skip to content

Conversation

@svandenb-dev
Copy link
Collaborator

Fixing a bug when single pin is found for reference.

closes #1627

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the create_port_on_component method where attempting to set the is_pin attribute on a list instead of a single pin object was causing an error when only one reference pin was found.

  • Fixed incorrect attribute assignment on list object by indexing to access the single pin element

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@svandenb-dev svandenb-dev enabled auto-merge (squash) November 5, 2025 12:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.89%. Comparing base (6f6fef7) to head (0d02ee5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1628   +/-   ##
=======================================
  Coverage   70.89%   70.89%           
=======================================
  Files         226      226           
  Lines       40690    40690           
=======================================
  Hits        28847    28847           
  Misses      11843    11843           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev merged commit 805037e into main Nov 5, 2025
28 checks passed
@svandenb-dev svandenb-dev deleted the create_port_on_component_fix branch November 5, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create port on component failing when single ref pin

5 participants