Skip to content

Case Reader Modifications. #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 29, 2023
Merged

Case Reader Modifications. #1486

merged 12 commits into from
Mar 29, 2023

Conversation

@prmukherj
Copy link
Collaborator

we need to get the case file path by reading the xml file (flprj).

@tejalprabhu01, could you please test this once now? cc. @seanpearsonuk

This was linked to issues Mar 21, 2023
Reading the project file failed with following error: More than one case file is present in: D:\Working_Dir #1478
Closed
Rename Case -> CaseFile and update doc #1464
Closed
@prmukherj prmukherj linked an issue Mar 21, 2023 that may be closed by this pull request
post_objects_container.Container missing docstring #1462
Closed
mkundu1
mkundu1 reviewed Mar 21, 2023
View reviewed changes
@mkundu1
Copy link
Contributor

mkundu1 commented Mar 21, 2023

@prmukherj @seanpearsonuk I talked with Patrick about parsing the .flprj file to avoid any possible ambiguity while parsing and here is the approach to take:

  1. Get the folder name from CurrentSimulation in the Metadata section..
  2. Go inside the section with the folder name (the class tag will be PFolder).
  3. Look for the Input section with Case subsection. Find the path inside the Target section.

seanpearsonuk
seanpearsonuk reviewed Mar 21, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Mar 23, 2023
View reviewed changes
@prmukherj
Update case_file.py
43ab5ee 
Removed a typo.
mkundu1
mkundu1 reviewed Mar 23, 2023
View reviewed changes
@prmukherj prmukherj marked this pull request as ready for review March 27, 2023 05:09
seanpearsonuk
seanpearsonuk reviewed Mar 28, 2023
View reviewed changes
@prmukherj prmukherj mentioned this pull request Mar 28, 2023
Merged
seanpearsonuk
seanpearsonuk approved these changes Mar 29, 2023
View reviewed changes
@prmukherj prmukherj merged commit cfa50a9 into main Mar 29, 2023
@prmukherj prmukherj deleted the maint/case_reader_modifications branch March 29, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@tejalprabhu01 tejalprabhu01 Awaiting requested review from tejalprabhu01

@ajain-work ajain-work Awaiting requested review from ajain-work

@hpohekar hpohekar Awaiting requested review from hpohekar hpohekar is a code owner

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

@alikasim72 alikasim72 Awaiting requested review from alikasim72

@h-krishnan h-krishnan Awaiting requested review from h-krishnan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@prmukherj @mkundu1 @seanpearsonuk