Skip to content

Conversation

@hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Mar 28, 2023

  1. Resolved Case class is undocumented #1484 n.b. this has since been updated to CaseFile following conflict resolution

image

----------------------------------------------------------------------------

  1. Resolved data_transfer module has unused docstring #1465

image

----------------------------------------------------------------------------

  1. Resolved fluent_connection module only exposes MonitorThread #1457

image

----------------------------------------------------------------------------

  1. Resolved asynchronous doc deeply nested #1453

image

----------------------------------------------------------------------------

  1. Resolved misleading session module doc #1456

image

image

----------------------------------------------------------------------------

  1. Resolved Tree of contents is in a keyhole #1460

image

----------------------------------------------------------------------------

  1. Resolved Unclickable attributes in session classes #1459

image

image

@hpohekar
Copy link
Collaborator Author

We have resolved regression related to navigation issue.

image

Corrected -

image

@hpohekar
Copy link
Collaborator Author

@seanpearsonuk

We have made _BaseMeshing public,

image

otherwise it was generating empty page as follows -

image

@hpohekar
Copy link
Collaborator Author

@seanpearsonuk

We have added and restructured .rst files to resolve #1459.

image

@seanpearsonuk
Copy link
Collaborator

@hpohekar I think you will have conflicts. case.py is now case_file.py. Case is CaseFile.

@hpohekar
Copy link
Collaborator Author

@hpohekar I think you will have conflicts. case.py is now case_file.py. Case is CaseFile.

@seanpearsonuk

We have resolved it.

image

@hpohekar
Copy link
Collaborator Author

@hpohekar I think you will have conflicts. case.py is now case_file.py. Case is CaseFile.

@seanpearsonuk

We have resolved it.

image

image

@hpohekar hpohekar changed the title Resolving doc issues Resolved doc issues Mar 29, 2023
@hpohekar hpohekar merged commit 3390d16 into main Mar 30, 2023
@hpohekar hpohekar deleted the doc/issue_fixes branch March 30, 2023 08:15
@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Mar 30, 2023

@hpohekar Some follow-up comments (sorry, I was still going through the updated docs)

  • Wherever we mention case reader, we could mention instead CaseFile class.
  • It would be useful if we can click on FluentConnection from <Session_class>.__init__(fluent_connection : FluentConnection)
  • This line "PRESENTLY SAME AS MESHING WITHOUT THE SWITCH TO SOLVER*" in session_pure_meshing is not needed (at least not in this format)

I will create a new issue to cover this work.

@seanpearsonuk seanpearsonuk mentioned this pull request Mar 30, 2023
@hpohekar
Copy link
Collaborator Author

@hpohekar Some follow-up comments (sorry, I was still going through the updated docs)

  • Wherever we mention case reader, we could mention instead CaseFile class.
  • It would be useful if we can click on FluentConnection from <Session_class>.__init__(fluent_connection : FluentConnection)
  • This line "PRESENTLY SAME AS MESHING WITHOUT THE SWITCH TO SOLVER*" in session_pure_meshing is not needed (at least not in this format)

I will create a new issue to cover this work.

No issues at all. We will try to resolve this as soon as possible. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants