Feat/additional example #1689
Merged
Feat/additional example #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarvalh-work
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
mkundu1,
prmukherj,
raph-luc and
seanpearsonuk
as code owners
seanpearsonuk
approved these changes
Jun 15, 2023
mkundu1
approved these changes
Jun 15, 2023
raph-luc
requested changes
Jun 15, 2023
Member
raph-luc
left a comment
raph-luc
left a comment
There was a problem hiding this comment.
Good job, tested it here and it worked fine. I haven't tested the doc build.
Merging main to update this branch might help with the tests.
If possible (not sure due to the doc build) I would strongly suggest using save_path and specifying cwd for launch_fluent so that the example and output files don't end up in multiple different locations and are easier to clean. A good default path to save is pyfluent.EXAMPLES_PATH.
@seanpearsonuk quick question: how do we decide which examples go in pyfluent-examples and which ones go here?
raph-luc
reviewed
Jun 15, 2023
Member
raph-luc
left a comment
raph-luc
left a comment
There was a problem hiding this comment.
Thanks, with the cwd change it is already much better as at least all Fluent input and output files end up in the same location.
raph-luc
reviewed
Jun 15, 2023
raph-luc
reviewed
Jun 15, 2023
raph-luc
approved these changes
Jun 15, 2023
prmukherj
approved these changes
Jun 16, 2023
… into feat/additional_example
hpohekar
approved these changes
Jun 22, 2023
seanpearsonuk
approved these changes
Jun 22, 2023
seanpearsonuk
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example added:
https://ansyshelp.ansys.com/account/secured?returnurl=/Views/Secured/corp/v231/en/flu_tg/flu_tg_oneram6_wing.html