launch_fluent doc #391
Merged
launch_fluent doc #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 9, 2022
| ], | ||
| "default": "3d", | ||
| "required": true, | ||
| "fluent_required": true, |
There was a problem hiding this comment.
:-). OK, so it means that Fluent requires that this argument be included onto the command line.
Can you put comments in a json file? Maybe document each entry at the top?
There was a problem hiding this comment.
Yeah, all fields starting within "fluent_" are fluent-specific in the json.
The json format doesn't have a syntax for adding comments. If we need to add comments, we need to add a field named "comment". Alternatively, the json can be replaced with yaml or toml which supports inline comments (Python 3.11 will natively support toml - link).
There was a problem hiding this comment.
Thanks Mainak. Makes sense.
dnwillia-work
approved these changes
May 9, 2022
ajain-work
approved these changes
May 10, 2022
seanpearsonuk
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.