Skip to content

refactor: transaction -> batch #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prmukherj merged 6 commits into from
Jul 11, 2025
Merged

refactor: transaction -> batch #4270

prmukherj merged 6 commits into from
Jul 11, 2025

Conversation

@prmukherj
Copy link
Collaborator

@prmukherj prmukherj commented Jul 10, 2025 •
edited
Loading

Update the names of all user facing transaction methods.

Also renames the user facing Transaction classes.

@prmukherj prmukherj linked an issue Jul 10, 2025 that may be closed by this pull request
Rename transaction to batch for clearer field-data batching API #4261
Closed
@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature labels Jul 10, 2025
@prmukherj prmukherj marked this pull request as ready for review July 11, 2025 04:54
@prmukherj
Copy link
Collaborator Author

prmukherj commented Jul 11, 2025 •
edited
Loading

Hi All,
Please provide your views if this should go in the next release.

hpohekar
hpohekar reviewed Jul 11, 2025
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Jul 11, 2025
View reviewed changes
@prmukherj prmukherj merged commit 8f4c84b into main Jul 11, 2025
34 checks passed
@prmukherj prmukherj deleted the refactor/transaction_to_batch branch July 11, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@hpohekar hpohekar hpohekar approved these changes

@mkundu1 mkundu1 Awaiting requested review from mkundu1 mkundu1 is a code owner

Assignees

No one assigned

Labels

documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename transaction to batch for clearer field-data batching API

5 participants

@prmukherj @seanpearsonuk @hpohekar @pyansys-ci-bot