Skip to content

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Jun 2, 2022

Currently the fluent_gui_help.xml file is not available in the Fluent image, thus checking in the file from RC2 package.

@@ -0,0 +1,3 @@
XML_HELP_PATCH = {
"flu_meshing_file_start_transcript": "Starts recording input and output in a file. A transcript file contains a complete record of all standard input to and output from Fluent (usually all keyboard and user interface input and all screen output).Start the transcription process with the file/start-transcript command, and end it with the file/stop-transcript command (or by exiting the program)."
Copy link
Contributor Author

@mkundu1 mkundu1 Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This id has problematic docstring in the xml file, this is the clean version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so that's why you had modified it before. Maybe Stephen can clean this up.

@@ -0,0 +1,16 @@
MENU_DESCRIPTIONS = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add custom descriptions here.


def _copy_tui_help_xml_file():
if os.getenv("PYFLUENT_LAUNCH_CONTAINER") == "1":
# Currently fluent_gui_help.xml is not available in the docker image
Copy link
Contributor Author

@mkundu1 mkundu1 Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will copy from the docker container (during CI run) when it is available

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, ok. I guess you will need to make sure with Laurence that this is there.

Copy link
Contributor Author

@mkundu1 mkundu1 Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file actually exists in the docker image. Updated the code accordingly.

@mkundu1 mkundu1 merged commit d12f22d into main Jun 3, 2022
@mkundu1 mkundu1 deleted the doc/tui-xml branch June 3, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy fluent_gui_help.xml from Fluent image instead of checking it in.

3 participants