Fix mutation of data_types causing order-dependent behavior

[Adir-html]

Fix mutation of data_types causing order-dependent behavior

The current implementation mutates the data_types list while iterating over it, which can lead to order-dependent behavior and inconsistent return types.

This PR replaces the mutation logic with a list comprehension that preserves order and avoids in-place modification:

data_types = [
    d_type if isinstance(d_type, SurfaceDataType)
    else SurfaceDataType(d_type)
    for d_type in data_types
]

This ensures consistent behavior regardless of input ordering.

Tested using the reproduction steps from the issue.

[ansys-cla-bot]

The following people have not signed the Contributors License Agreement (CLA):

• @Adir1367

Read the CLA in the link above and sign it by clicking the link below:

Login with GitHub

You will receive a confirmation as soon as your signature is captured.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

[Copilot]

Pull request overview

Fixes order-dependent behavior in FileFieldData._get_surface_data() by eliminating in-place mutation of the data_types iterable during normalization to SurfaceDataType.

Changes:

• Replace in-loop remove/append mutation of data_types with a new list constructed via comprehension to preserve input order.
• Ensure data_types entries are normalized to SurfaceDataType before downstream membership checks.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new list comprehension is indented inconsistently with the surrounding method body and will be reformatted by Black (and may fail formatting checks in CI/pre-commit). Please re-indent this block to Black-style indentation so the comprehension lines align under the opening bracket within the method scope.

Suggested change

	d_type if isinstance(d_type, SurfaceDataType)
	else SurfaceDataType(d_type)
	for d_type in data_types
	]
	d_type if isinstance(d_type, SurfaceDataType)
	else SurfaceDataType(d_type)
	for d_type in data_types
	]

[seanpearsonuk]

Great. As well as not mutating the container while iterating, it also uses a positive type check.

[Gobot1234]

You don't really need the type check here as suggested in the original issue as Enum(Enum.member) -> Enum.member

[prmukherj]

@Adir-html, could you please fix the code styling issue in this PR. There is a co-pilot suggestion as well, please feel free to commit it.
Thank you.

[Adir-html]

@copilot apply changes based on the comments in this thread