Skip to content

Replaced python sdk usage with docker cli #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2022
Merged

Replaced python sdk usage with docker cli #800

merged 2 commits into from
Aug 30, 2022

Conversation

@hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Aug 29, 2022 •
edited
Loading

Replaced python sdk usage with docker cli in test_fluent_session.py.

image

@hpohekar hpohekar requested a review from mkundu1 August 29, 2022 15:23
mkundu1
mkundu1 reviewed Aug 29, 2022
View reviewed changes
@mkundu1
Copy link
Contributor

mkundu1 commented Aug 29, 2022

Please also remove the docker dependency from requirements\requirements_tests.txt.

@hpohekar
Copy link
Collaborator Author

hpohekar commented Aug 30, 2022

Please also remove the docker dependency from requirements\requirements_tests.txt.

Done. Thank you.

@hpohekar hpohekar marked this pull request as ready for review August 30, 2022 05:47
@hpohekar hpohekar linked an issue Aug 30, 2022 that may be closed by this pull request
refactor docker code in fluent_container.py #597
Closed
@hpohekar hpohekar merged commit 71a4b9e into main Aug 30, 2022
@hpohekar hpohekar deleted the fix/refactoring_fluent_container branch August 30, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkundu1 mkundu1 mkundu1 approved these changes

@prmukherj prmukherj prmukherj approved these changes

@seanpearsonuk seanpearsonuk Awaiting requested review from seanpearsonuk seanpearsonuk is a code owner

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor docker code in fluent_container.py

4 participants

@hpohekar @mkundu1 @prmukherj